fix: Update async utils to remove upcoming deprecated call #6297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawflau
reviewed
Nov 17, 2023
|
|
||
| LOG = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| async def _run_given_tasks_async(tasks, event_loop=asyncio.get_event_loop(), executor=None): | ||
| async def _run_given_tasks_async( | ||
| tasks: List[Callable], event_loop: AbstractEventLoop, executor: Optional[ThreadPoolExecutor] = None |
There was a problem hiding this comment.
Did we use the default value at all?
There was a problem hiding this comment.
No, since the creation of this util the event loop was always specified and the helper methods are only called within this file:
aws-sam-cli/samcli/lib/utils/async_utils.py
Lines 127 to 131 in bbaefff
mndeveci
approved these changes
Nov 17, 2023
mndeveci
reviewed
Nov 17, 2023
| @@ -111,7 +116,7 @@ def add_async_task(self, function, *args): | |||
| """ | |||
| self._async_tasks.append(partial(function, *args)) | |||
|
|
|||
| def run_async(self, default_executor=True): | |||
| def run_async(self, default_executor: bool = True) -> list: | |||
There was a problem hiding this comment.
Thanks for adding type definitions!
hawflau
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
None.
Why is this change necessary?
asyncio.get_event_loop()is being deprecated in the future. Deprecation warns are starting to appear, which will cause tests to fail since warnings are treated as errors.How does it address the issue?
Removes the call to
asyncio.get_event_loop()as a default value for the tasks.What side effects does this change have?
None.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.