Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consider parameter overrides during sam sync #6426

Merged
merged 8 commits into from
Dec 12, 2023
Merged

Conversation

bentvelj
Copy link
Contributor

@bentvelj bentvelj commented Dec 8, 2023

Which issue(s) does this change fix?

#6172

Why is this change necessary?

sam sync did not consider parameter overrides when detecting changes. This leads to unexpected behaviour when the customer will set new parameter overrides when starting a sync, but their stack will behave with the old parameters.

How does it address the issue?

When deciding whether or not to skip infra sync, we now ensure that parameter_overridesstack parameters. Otherwise, sync infrastructure.

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bentvelj bentvelj marked this pull request as ready for review December 8, 2023 23:10
@bentvelj bentvelj requested a review from a team as a code owner December 8, 2023 23:10
@bentvelj bentvelj changed the title Bentvels fix 6172 Consider Parameter Overrides during sam sync Dec 8, 2023
samcli/lib/sync/infra_sync_executor.py Outdated Show resolved Hide resolved
tests/unit/lib/sync/test_infra_sync_executor.py Outdated Show resolved Hide resolved
samcli/lib/sync/infra_sync_executor.py Outdated Show resolved Hide resolved
@mndeveci mndeveci changed the title Consider Parameter Overrides during sam sync fix: consider parameter overrides during sam sync Dec 8, 2023
samcli/lib/sync/infra_sync_executor.py Outdated Show resolved Hide resolved
samcli/lib/sync/infra_sync_executor.py Outdated Show resolved Hide resolved
samcli/lib/sync/infra_sync_executor.py Outdated Show resolved Hide resolved
samcli/lib/sync/infra_sync_executor.py Outdated Show resolved Hide resolved
@bentvelj bentvelj added this pull request to the merge queue Dec 12, 2023
Merged via the queue into develop with commit 80f9f3e Dec 12, 2023
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants