-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: consider parameter overrides during sam sync #6426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentvelj
changed the title
Bentvels fix 6172
Consider Parameter Overrides during sam sync
Dec 8, 2023
sidhujus
approved these changes
Dec 8, 2023
mndeveci
suggested changes
Dec 8, 2023
mndeveci
changed the title
Consider Parameter Overrides during sam sync
fix: consider parameter overrides during sam sync
Dec 8, 2023
mndeveci
reviewed
Dec 9, 2023
mndeveci
suggested changes
Dec 9, 2023
mndeveci
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
#6172
Why is this change necessary?
sam sync
did not consider parameter overrides when detecting changes. This leads to unexpected behaviour when the customer will set new parameter overrides when starting a sync, but their stack will behave with the old parameters.How does it address the issue?
When deciding whether or not to skip infra sync, we now ensure that
parameter_overrides
⊆stack parameters
. Otherwise, sync infrastructure.What side effects does this change have?
N/A
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.