Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/dotnet8 #6677

Closed
wants to merge 3 commits into from
Closed

Feat/dotnet8 #6677

wants to merge 3 commits into from

Conversation

Beau-Gosse-dev
Copy link
Contributor

Why is this change necessary?

To add support for .NET 8 Lambdas (managed runtime)

How does it address the issue?

Add .NET 8 option for deploying to Lambda

What side effects does this change have?

None

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • [X ] Write design document if needed (Do I need to write a design document?)
  • [X ] Write/update unit tests
  • [X ] Write/update integration tests
  • [X ] Write/update functional tests if needed
  • [ X] make pr passes (Except FAIL Required test coverage of 94% not reached. Total coverage: 30.60%)
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Beau-Gosse-dev Beau-Gosse-dev requested a review from a team as a code owner February 12, 2024 19:16
@github-actions github-actions bot added area/local/start-api sam local start-api command area/build sam build command area/local/invoke sam local invoke command area/local/start-invoke area/schema JSON schema file pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Feb 12, 2024
@Beau-Gosse-dev
Copy link
Contributor Author

Cherry picked from #6429 to use correct feat/dotnet8 branch instead of develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentvelj bentvelj Awaiting requested review from bentvelj bentvelj was automatically assigned from aws/serverless-application-experience-sbt

@mildaniel mildaniel Awaiting requested review from mildaniel mildaniel was automatically assigned from aws/serverless-application-experience-sbt

Assignees
No one assigned
Labels
area/build sam build command area/local/invoke sam local invoke command area/local/start-api sam local start-api command area/local/start-invoke area/schema JSON schema file pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Beau-Gosse-dev