Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add python3.13 runtime support #7561

Merged
merged 11 commits into from
Nov 11, 2024
Merged

Conversation

hnnasit
Copy link
Contributor

@hnnasit hnnasit commented Oct 12, 2024

Which issue(s) does this change fix?

Why is this change necessary?

To add python3.13 runtime support

How does it address the issue?

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • [] Write/update functional tests if needed
  • make pr passes
  • [] make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added area/local/start-api sam local start-api command area/build sam build command area/local/invoke sam local invoke command area/local/start-invoke area/schema JSON schema file pr/internal labels Oct 12, 2024
@hnnasit hnnasit marked this pull request as ready for review November 4, 2024 23:07
@hnnasit hnnasit requested a review from a team as a code owner November 4, 2024 23:07
@hnnasit hnnasit requested review from dkphm and jysheng123 November 4, 2024 23:07
@hnnasit
Copy link
Contributor Author

hnnasit commented Nov 4, 2024

make pr expected to fail until the init templates hash with python3.13 is merged since 1 of the test uses latest python project.

@hnnasit
Copy link
Contributor Author

hnnasit commented Nov 10, 2024

Canary tests were run against the changes in this PR (Linux and Windows). The only tests failing are for sam build -u commands which pulls unreleased py313 images.

Linux

BuildIntegTestingJavaPythonProvided

FAILED tests/integration/buildcmd/test_build_cmd_python.py::TestBuildCommand_PythonFunctions_WithDocker::test_with_default_requirements_al2023_1_python3_13 - AssertionError: 'template.yaml' not found in []
FAILED tests/integration/buildcmd/test_build_cmd_python.py::TestBuildCommand_PythonFunctions_With_Specified_Architecture::test_with_default_requirements_al2023_5_python3_13 - AssertionError: 'template.yaml' not found in []

Error: Could not find public.ecr.aws/sam/build-python3.13:latest-x86_64 image locally and failed to pull it from docker.

BuildIntegTestingArm64

FAILED tests/integration/buildcmd/test_build_cmd_arm64.py::TestBuildCommand_PythonFunctions_With_Specified_Architecture_arm64::test_with_default_requirements_al2023_1_python3_13 - AssertionError: 'template.yaml' not found in []

Error: Could not find public.ecr.aws/sam/build-python3.13:latest-arm64 image locally and failed to pull it from docker.
------------

Windows

FAILED tests/integration/buildcmd/test_build_cmd_arm64.py::TestBuildCommand_PythonFunctions_With_Specified_Architecture_arm64::test_with_default_requirements_al2023_1_python3_13 - AssertionError: 'template.yaml' not found in []
FAILED tests/integration/buildcmd/test_build_cmd_python.py::TestBuildCommand_PythonFunctions_WithDocker::test_with_default_requirements_al2023_1_python3_13 - AssertionError: 'template.yaml' not found in []
FAILED tests/integration/buildcmd/test_build_cmd_python.py::TestBuildCommand_PythonFunctions_With_Specified_Architecture::test_with_default_requirements_al2023_5_python3_13 - AssertionError: 'template.yaml' not found in []

Starting Build inside a container
Below nested stacks(s) specify non-local URL(s), which are unsupported:
- ExampleNestedStack
Skipping building resources inside these nested stacks.
Building codeuri: C:\source\tests\integration\testdata\buildcmd\Python runtime: python3.13 architecture: x86_64 functions: Function
Error: Could not find public.ecr.aws/sam/build-python3.13:latest-x86_64 image locally and failed to pull it from docker.

@hnnasit hnnasit enabled auto-merge November 10, 2024 20:58
@hnnasit hnnasit added this pull request to the merge queue Nov 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 10, 2024
@hnnasit hnnasit added this pull request to the merge queue Nov 11, 2024
Merged via the queue into aws:develop with commit 73d28d2 Nov 11, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build sam build command area/local/invoke sam local invoke command area/local/start-api sam local start-api command area/local/start-invoke area/schema JSON schema file pr/internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants