Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add nodejs22.x runtime support #7624

Merged
merged 7 commits into from
Nov 21, 2024
Merged

feat: Add nodejs22.x runtime support #7624

merged 7 commits into from
Nov 21, 2024

Conversation

hnnasit
Copy link
Contributor

@hnnasit hnnasit commented Oct 29, 2024

Why is this change necessary?

To add nodejs22.x runtime support

How does it address the issue?

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added area/local/start-api sam local start-api command area/build sam build command area/local/invoke sam local invoke command area/local/start-invoke area/schema JSON schema file pr/internal labels Oct 29, 2024
@hnnasit hnnasit marked this pull request as ready for review November 20, 2024 15:49
@hnnasit hnnasit requested a review from a team as a code owner November 20, 2024 15:49
@hnnasit hnnasit requested review from hawflau and lucashuy November 20, 2024 15:49
@mndeveci mndeveci enabled auto-merge November 21, 2024 01:08
@mndeveci mndeveci added this pull request to the merge queue Nov 21, 2024
Merged via the queue into aws:develop with commit ba91737 Nov 21, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkphm dkphm dkphm approved these changes

@lucashuy lucashuy lucashuy approved these changes

@hawflau hawflau Awaiting requested review from hawflau hawflau was automatically assigned from aws/serverless-application-experience-sbt

Assignees
No one assigned
Labels
area/build sam build command area/local/invoke sam local invoke command area/local/start-api sam local start-api command area/local/start-invoke area/schema JSON schema file pr/internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hnnasit @lucashuy @dkphm @mndeveci