Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JMESPath dependency #2284

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Update JMESPath dependency #2284

merged 1 commit into from
Dec 7, 2018

Conversation

jasdel
Copy link
Contributor

@jasdel jasdel commented Nov 16, 2018

Updates github.com/jmespath/go-jmespath to the latest version of JMESPath.

Fix #1907 #2266

@jasdel jasdel self-assigned this Nov 16, 2018
@jasdel
Copy link
Contributor Author

jasdel commented Nov 19, 2018

Hi @thepudds, this PR updates the SDK's go-jmespath dependency to the latest version. When creating the PR i'm unable to reproduce an error you experienced with golang/go#28396. Does this PR resolve the issue you were experiencing getting the SDK?

@jasdel jasdel added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed review-needed labels Nov 19, 2018
@jasdel jasdel force-pushed the updateDependencies branch from 41241be to d643294 Compare November 27, 2018 05:55
@jasdel jasdel force-pushed the updateDependencies branch from d643294 to 72af164 Compare December 3, 2018 18:07
@jasdel jasdel merged commit cab8bf9 into aws:master Dec 7, 2018
@jasdel jasdel deleted the updateDependencies branch December 7, 2018 17:56
jasdel added a commit that referenced this pull request Dec 14, 2018
Updates Go dep's lock file to contain the correct tracking hash. The Gopkg.toml file was updated in #2284 but the lock file was missed.
@shaunc
Copy link

shaunc commented Jan 8, 2019

I'm still having problems with this (using modules):

$ go version
go version go1.11.3 darwin/amd64

$ go get github.com/jmespath/go-jmespath@latest
go: finding github.com/jmespath/go-jmespath latest
# github.com/jmespath/go-jmespath
/Users/shauncutts/pkg/mod/github.com/jmespath/[email protected]/api.go:8:7: undefined: ASTNode
/Users/shauncutts/pkg/mod/github.com/jmespath/[email protected]/api.go:9:8: undefined: treeInterpreter

$ go get github.com/jmespath/[email protected]
$

and the latest one seems to be loaded by default by both v1 and v2 of the sdk.

@jasdel
Copy link
Contributor Author

jasdel commented Jan 8, 2019

Thanks for the update @shaunc I'm having difficulties reproducing this issue. Could you try cleaning your Go cache, and modcache? With a clean cache and getting the latest, or specific commit go-jmespath i'm unable to reproduce any error.

go clean -cache
go clean -modcache

go get github.com/jmespath/go-jmespath@latest

@shaunc
Copy link

shaunc commented Jan 9, 2019

@jasdel -- In fact, that worked!

Sorry -- I'm a go newbie... if this were npm I would have thought of the analogous on my own. :)

Thank you!

@jasdel
Copy link
Contributor Author

jasdel commented Jan 9, 2019

Great, glad that resolved the issue!

@diehlaws diehlaws removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Nov 7, 2019
@MaerF0x0
Copy link

MaerF0x0 commented Mar 5, 2020

For others coming from search engines.

I was able to fix

/Users/me/pkg/mod/github.com/jmespath/[email protected]/api.go:8:7: undefined: ASTNode
/Users/me/pkg/mod/github.com/jmespath/[email protected]/api.go:9:8: undefined: treeInterpreter

by running

rm -rf vendor/ 
go clean -cache
go clean -modcache
go mod vendor

Which probably was overkill, but worked 🤷‍♂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go-jmespath commit#0b12d6b5 instead of release#0.2.2
6 participants