Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix trailing whitespace #2489

Merged
merged 1 commit into from
Mar 8, 2019
Merged

fix trailing whitespace #2489

merged 1 commit into from
Mar 8, 2019

Conversation

mikecook
Copy link
Contributor

@mikecook mikecook commented Mar 5, 2019

No description provided.

@jasdel
Copy link
Contributor

jasdel commented Mar 6, 2019

Thanks for creating this PR @mikecook would you mind updating the PR to exclude the /model/**/*.json files. These are provided upstream by the service teams, and will be overritten on the next update.

I'll see if i can upstream cleanup to our tooling to remove trailing whitespace from the model files.

jasdel
jasdel approved these changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this update. The changes look good, we'll get this merged in.

@jasdel jasdel merged commit b2eca01 into aws:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasdel jasdel jasdel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikecook @jasdel