Make all generated model classes final

aws · May 31, 2018 · faeb049 · faeb049
1 parent b1bdd3f
commit faeb049
Show file tree

Hide file tree

Showing 20 changed files with 271 additions and 263 deletions.
diff --git a/codegen/src/main/java/software/amazon/awssdk/codegen/poet/model/AwsServiceModel.java b/codegen/src/main/java/software/amazon/awssdk/codegen/poet/model/AwsServiceModel.java
@@ -74,7 +74,7 @@ public AwsServiceModel(IntermediateModel intermediateModel, ShapeModel shapeMode
     @Override
     public TypeSpec poetSpec() {
         TypeSpec.Builder specBuilder = TypeSpec.classBuilder(shapeModel.getShapeName())
-                                               .addModifiers(Modifier.PUBLIC)
+                                               .addModifiers(Modifier.PUBLIC, Modifier.FINAL)
                                                .addAnnotation(PoetUtils.GENERATED)
                                                .addSuperinterfaces(modelSuperInterfaces())
                                                .superclass(modelSuperClass())

diff --git a/codegen/src/test/resources/software/amazon/awssdk/codegen/poet/model/alltypesrequest.java b/codegen/src/test/resources/software/amazon/awssdk/codegen/poet/model/alltypesrequest.java
@@ -25,7 +25,7 @@
 /**
  */
 @Generated("software.amazon.awssdk:codegen")
-public class AllTypesRequest extends JsonProtocolTestsRequest implements
+public final class AllTypesRequest extends JsonProtocolTestsRequest implements
                                                               ToCopyableBuilder<AllTypesRequest.Builder, AllTypesRequest> {
     private final String stringMember;
 

diff --git a/codegen/src/test/resources/software/amazon/awssdk/codegen/poet/model/alltypesresponse.java b/codegen/src/test/resources/software/amazon/awssdk/codegen/poet/model/alltypesresponse.java
@@ -24,7 +24,7 @@
 /**
  */
 @Generated("software.amazon.awssdk:codegen")
-public class AllTypesResponse extends JsonProtocolTestsResponse implements
+public final class AllTypesResponse extends JsonProtocolTestsResponse implements
                                                                 ToCopyableBuilder<AllTypesResponse.Builder, AllTypesResponse> {
     private final String stringMember;
 

diff --git a/codegen/src/test/resources/software/amazon/awssdk/codegen/poet/model/basetype.java b/codegen/src/test/resources/software/amazon/awssdk/codegen/poet/model/basetype.java
@@ -14,7 +14,7 @@
 /**
  */
 @Generated("software.amazon.awssdk:codegen")
-public class BaseType implements StructuredPojo, ToCopyableBuilder<BaseType.Builder, BaseType> {
+public final class BaseType implements StructuredPojo, ToCopyableBuilder<BaseType.Builder, BaseType> {
     private final String baseMember;
 
     private BaseType(BuilderImpl builder) {

diff --git a/...n/src/test/resources/software/amazon/awssdk/codegen/poet/model/emptymodeledexception.java b/...n/src/test/resources/software/amazon/awssdk/codegen/poet/model/emptymodeledexception.java
@@ -7,7 +7,7 @@
 /**
  */
 @Generated("software.amazon.awssdk:codegen")
-public class EmptyModeledException extends JsonProtocolTestsException implements
+public final class EmptyModeledException extends JsonProtocolTestsException implements
         ToCopyableBuilder<EmptyModeledException.Builder, EmptyModeledException> {
     private EmptyModeledException(BuilderImpl builder) {
         super(builder.message);

diff --git a/codegen/src/test/resources/software/amazon/awssdk/codegen/poet/model/enumtype.java b/codegen/src/test/resources/software/amazon/awssdk/codegen/poet/model/enumtype.java
@@ -7,7 +7,7 @@
 /**
  */
 @Generated("software.amazon.awssdk:codegen")
-public class EnumType {
+public final class EnumType {
     private EnumType(EnumType.BuilderImpl builder) {
     }
 

diff --git a/...src/test/resources/software/amazon/awssdk/codegen/poet/model/nestedcontainersrequest.java b/...src/test/resources/software/amazon/awssdk/codegen/poet/model/nestedcontainersrequest.java
@@ -16,7 +16,7 @@
 /**
  */
 @Generated("software.amazon.awssdk:codegen")
-public class NestedContainersRequest extends JsonProtocolTestsRequest implements
+public final class NestedContainersRequest extends JsonProtocolTestsRequest implements
                                                                       ToCopyableBuilder<NestedContainersRequest.Builder, NestedContainersRequest> {
     private final List<List<String>> listOfListOfStrings;
 

diff --git a/...rc/test/resources/software/amazon/awssdk/codegen/poet/model/nestedcontainersresponse.java b/...rc/test/resources/software/amazon/awssdk/codegen/poet/model/nestedcontainersresponse.java
@@ -14,7 +14,7 @@
 /**
  */
 @Generated("software.amazon.awssdk:codegen")
-public class NestedContainersResponse extends JsonProtocolTestsResponse implements
+public final class NestedContainersResponse extends JsonProtocolTestsResponse implements
                                                                         ToCopyableBuilder<NestedContainersResponse.Builder, NestedContainersResponse> {
     private final List<List<String>> listOfListOfStrings;
 

diff --git a/...ources/software/amazon/awssdk/codegen/poet/model/operationwithnoinputoroutputrequest.java b/...ources/software/amazon/awssdk/codegen/poet/model/operationwithnoinputoroutputrequest.java
@@ -9,7 +9,7 @@
 import software.amazon.awssdk.utils.builder.ToCopyableBuilder;
 
 @Generated("software.amazon.awssdk:codegen")
-public class OperationWithNoInputOrOutputRequest extends JsonProtocolTestsRequest implements
+public final class OperationWithNoInputOrOutputRequest extends JsonProtocolTestsRequest implements
                                                                                   ToCopyableBuilder<OperationWithNoInputOrOutputRequest.Builder, OperationWithNoInputOrOutputRequest> {
     private OperationWithNoInputOrOutputRequest(BuilderImpl builder) {
         super(builder);

diff --git a/...urces/software/amazon/awssdk/codegen/poet/model/operationwithnoinputoroutputresponse.java b/...urces/software/amazon/awssdk/codegen/poet/model/operationwithnoinputoroutputresponse.java
@@ -7,7 +7,7 @@
 import software.amazon.awssdk.utils.builder.ToCopyableBuilder;
 
 @Generated("software.amazon.awssdk:codegen")
-public class OperationWithNoInputOrOutputResponse extends JsonProtocolTestsResponse implements
+public final class OperationWithNoInputOrOutputResponse extends JsonProtocolTestsResponse implements
                                                                                     ToCopyableBuilder<OperationWithNoInputOrOutputResponse.Builder, OperationWithNoInputOrOutputResponse> {
     private OperationWithNoInputOrOutputResponse(BuilderImpl builder) {
         super(builder);

diff --git a/...gen/src/test/resources/software/amazon/awssdk/codegen/poet/model/recursivestructtype.java b/...gen/src/test/resources/software/amazon/awssdk/codegen/poet/model/recursivestructtype.java
@@ -22,7 +22,7 @@
 /**
  */
 @Generated("software.amazon.awssdk:codegen")
-public class RecursiveStructType implements StructuredPojo, ToCopyableBuilder<RecursiveStructType.Builder, RecursiveStructType> {
+public final class RecursiveStructType implements StructuredPojo, ToCopyableBuilder<RecursiveStructType.Builder, RecursiveStructType> {
     private final String noRecurse;
 
     private final RecursiveStructType recursiveStruct;

diff --git a/codegen/src/test/resources/software/amazon/awssdk/codegen/poet/model/simplestruct.java b/codegen/src/test/resources/software/amazon/awssdk/codegen/poet/model/simplestruct.java
@@ -14,7 +14,7 @@
 /**
  */
 @Generated("software.amazon.awssdk:codegen")
-public class SimpleStruct implements StructuredPojo, ToCopyableBuilder<SimpleStruct.Builder, SimpleStruct> {
+public final class SimpleStruct implements StructuredPojo, ToCopyableBuilder<SimpleStruct.Builder, SimpleStruct> {
     private final String stringMember;
 
     private SimpleStruct(BuilderImpl builder) {

diff --git a/...t/resources/software/amazon/awssdk/codegen/poet/model/streaminginputoperationrequest.java b/...t/resources/software/amazon/awssdk/codegen/poet/model/streaminginputoperationrequest.java
@@ -11,7 +11,7 @@
 /**
  */
 @Generated("software.amazon.awssdk:codegen")
-public class StreamingInputOperationRequest extends JsonProtocolTestsRequest implements
+public final class StreamingInputOperationRequest extends JsonProtocolTestsRequest implements
                                                                              ToCopyableBuilder<StreamingInputOperationRequest.Builder, StreamingInputOperationRequest> {
     private StreamingInputOperationRequest(BuilderImpl builder) {
         super(builder);

diff --git a/.../resources/software/amazon/awssdk/codegen/poet/model/streaminginputoperationresponse.java b/.../resources/software/amazon/awssdk/codegen/poet/model/streaminginputoperationresponse.java
@@ -7,7 +7,7 @@
 import software.amazon.awssdk.utils.builder.ToCopyableBuilder;
 
 @Generated("software.amazon.awssdk:codegen")
-public class StreamingInputOperationResponse extends JsonProtocolTestsResponse implements
+public final class StreamingInputOperationResponse extends JsonProtocolTestsResponse implements
                                                                                ToCopyableBuilder<StreamingInputOperationResponse.Builder, StreamingInputOperationResponse> {
     private StreamingInputOperationResponse(BuilderImpl builder) {
         super(builder);

diff --git a/.../resources/software/amazon/awssdk/codegen/poet/model/streamingoutputoperationrequest.java b/.../resources/software/amazon/awssdk/codegen/poet/model/streamingoutputoperationrequest.java
@@ -9,7 +9,7 @@
 import software.amazon.awssdk.utils.builder.ToCopyableBuilder;
 
 @Generated("software.amazon.awssdk:codegen")
-public class StreamingOutputOperationRequest extends JsonProtocolTestsRequest implements
+public final class StreamingOutputOperationRequest extends JsonProtocolTestsRequest implements
                                                                               ToCopyableBuilder<StreamingOutputOperationRequest.Builder, StreamingOutputOperationRequest> {
     private StreamingOutputOperationRequest(BuilderImpl builder) {
         super(builder);

diff --git a/...resources/software/amazon/awssdk/codegen/poet/model/streamingoutputoperationresponse.java b/...resources/software/amazon/awssdk/codegen/poet/model/streamingoutputoperationresponse.java
@@ -9,7 +9,7 @@
 /**
  */
 @Generated("software.amazon.awssdk:codegen")
-public class StreamingOutputOperationResponse extends JsonProtocolTestsResponse implements
+public final class StreamingOutputOperationResponse extends JsonProtocolTestsResponse implements
                                                                                 ToCopyableBuilder<StreamingOutputOperationResponse.Builder, StreamingOutputOperationResponse> {
     private StreamingOutputOperationResponse(BuilderImpl builder) {
         super(builder);

diff --git a/...rc/test/resources/software/amazon/awssdk/codegen/poet/model/structwithnestedblobtype.java b/...rc/test/resources/software/amazon/awssdk/codegen/poet/model/structwithnestedblobtype.java
@@ -16,8 +16,9 @@
 /**
  */
 @Generated("software.amazon.awssdk:codegen")
-public class StructWithNestedBlobType implements StructuredPojo,
-                                                 ToCopyableBuilder<StructWithNestedBlobType.Builder, StructWithNestedBlobType> {
+public final class StructWithNestedBlobType implements StructuredPojo,
+                                                       ToCopyableBuilder<StructWithNestedBlobType.Builder,
+                                                           StructWithNestedBlobType> {
     private final ByteBuffer nestedBlob;
 
     private StructWithNestedBlobType(BuilderImpl builder) {

diff --git a/...gen/src/test/resources/software/amazon/awssdk/codegen/poet/model/structwithtimestamp.java b/...gen/src/test/resources/software/amazon/awssdk/codegen/poet/model/structwithtimestamp.java
@@ -15,7 +15,7 @@
 /**
  */
 @Generated("software.amazon.awssdk:codegen")
-public class StructWithTimestamp implements StructuredPojo, ToCopyableBuilder<StructWithTimestamp.Builder, StructWithTimestamp> {
+public final class StructWithTimestamp implements StructuredPojo, ToCopyableBuilder<StructWithTimestamp.Builder, StructWithTimestamp> {
     private final Instant nestedTimestamp;
 
     private StructWithTimestamp(BuilderImpl builder) {

diff --git a/codegen/src/test/resources/software/amazon/awssdk/codegen/poet/model/subtypeone.java b/codegen/src/test/resources/software/amazon/awssdk/codegen/poet/model/subtypeone.java
@@ -14,7 +14,7 @@
 /**
  */
 @Generated("software.amazon.awssdk:codegen")
-public class SubTypeOne implements StructuredPojo, ToCopyableBuilder<SubTypeOne.Builder, SubTypeOne> {
+public final class SubTypeOne implements StructuredPojo, ToCopyableBuilder<SubTypeOne.Builder, SubTypeOne> {
     private final String subTypeOneMember;
 
     private SubTypeOne(BuilderImpl builder) {