Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AquisitionTimeout is a factor of 1000 off. #340

Closed
loosemoose opened this issue Dec 11, 2017 · 1 comment
Closed

AquisitionTimeout is a factor of 1000 off. #340

loosemoose opened this issue Dec 11, 2017 · 1 comment
Assignees
@shorea
Labels
bug This issue is a bug.

Comments

@loosemoose
Copy link

The following line should return milliseconds, not seconds:

aws-sdk-java-v2/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/internal/NettyConfiguration.java

Line 88 in 32a5c48

return factory.connectionAquisitionTimeout().map(d -> saturatedCast(d.getSeconds())).orElseGet(this::connectionTimeout);

@shorea shorea added the bug This issue is a bug. label Dec 11, 2017
@shorea shorea self-assigned this Dec 11, 2017
@shorea shorea mentioned this issue Dec 12, 2017
Merged
5 tasks
shorea pushed a commit that referenced this issue Dec 13, 2017
Fixing Issue #340
799c473
shorea pushed a commit that referenced this issue Dec 14, 2017
@shorea
Fixing Issue #340
d3c13ab
@dagnir
Copy link
Contributor

dagnir commented Dec 14, 2017

Fixed in #345

@dagnir dagnir closed this as completed Dec 14, 2017
shorea pushed a commit that referenced this issue Aug 3, 2018
@shorea
Fixing Issue #340
851b21f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shorea shorea

Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dagnir @loosemoose @shorea