Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RetryPolicy Builder does not have throttlingBackoffStrategy method #646

Closed
hisener opened this issue Aug 3, 2018 · 3 comments · Fixed by #647
Closed

RetryPolicy Builder does not have throttlingBackoffStrategy method #646

hisener opened this issue Aug 3, 2018 · 3 comments · Fixed by #647
Labels
bug This issue is a bug.

Comments

@hisener
Copy link

hisener commented Aug 3, 2018

Expected Behavior

RetryPolicy.Builder interface should have following two methods:

  • Builder throttlingBackoffStrategy(BackoffStrategy backoffStrategy);
  • BackoffStrategy throttlingBackoffStrategy();

Current Behavior

throttlingBackoffStrategy is not overridable in RetryPolicy.

Possible Solution

Add these methods above in RetryPolicy.Builder.

Steps to Reproduce (for bugs)

n/a

Context

n/a

Your Environment

  • AWS Java SDK version used: 2.0.0-preview-11
  • JDK version used: 1.8.0_172
  • Operating System and version: macOS High Sierra 10.13.4
@zoewangg
Copy link
Contributor

zoewangg commented Aug 3, 2018

Oops, looks like we only have the api in the private BulderImpl class. Thanks for reporting! I'll work on the fix for this.

public Builder throttlingBackoffStrategy(BackoffStrategy backoffStrategy) {
this.backoffStrategy = backoffStrategy;
return this;

@zoewangg zoewangg added Bug Fix bug This issue is a bug. and removed Bug Fix labels Aug 3, 2018
@hisener
Copy link
Author

hisener commented Aug 3, 2018

👍

By the way, do you have a release schedule for the next preview releases, possible release candidates etc.?

@zoewangg
Copy link
Contributor

zoewangg commented Aug 8, 2018

@hisener Hi, the fix has been merged to master but we don't have a date for the next preview release at this moment. We will let you know when it's ready to be released.

aws-sdk-java-automation added a commit that referenced this issue Oct 18, 2019
…8356582e

Pull request: release <- staging/b9d6abb3-0350-4abc-a0dd-b7a28356582e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants