Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppport SdkResponseMetadata #670

Closed
zoewangg opened this issue Aug 24, 2018 · 2 comments
Closed

Suppport SdkResponseMetadata #670

zoewangg opened this issue Aug 24, 2018 · 2 comments
Labels
1.x Parity feature-request A feature should be added or improved.

Comments

@zoewangg
Copy link
Contributor

v1 supports ResponseMetadata to allow customers to retrieve useful debugging information such as requestId, hostId for the request. Currently, it's not implemented in v2.

@zoewangg
Copy link
Contributor Author

For now, the requestIds might be retrieved from the response headers for some services.

For example:

s3:

        HeadObjectResponse response = s3.headObject(HeadObjectRequest.builder()
                                                                     .bucket(BUCKET_NAME)
                                                                     .key(key)
                                                                     .build());

        response.sdkHttpResponse().headers().get("x-amz-request-id");
        response.sdkHttpResponse().headers().get("x-amz-id-2");

DynamoDB:

     result.sdkHttpResponse().headers().get("x-amzn-RequestId");

@zoewangg
Copy link
Contributor Author

Implemented in #701

@justnance justnance added feature-request A feature should be added or improved. and removed Feature Request labels Apr 19, 2019
aws-sdk-java-automation pushed a commit that referenced this issue Nov 15, 2019
Revert "Merge pull request #1187 from aws/finks/unsupported-payloads"
jrobinso pushed a commit to igvteam/igv that referenced this issue Feb 20, 2020
* Naive headObject method wrapper for GLACIER_ARCHIVE restore. Observed header combinations while debugging do not seem to align docs, more investigation is needed.

* The AWS SDK Java v2 HeadObject.restore() is not reliable as of version 2.8.5, see aws/aws-sdk-java-v2#670 (comment)

* Other than fixing the Glacier/Archive tier error handling, also implemented support for File->Load From URL if the user knows the S3 URL, they can paste it there directly. Also aws-java-sdk-v2 version bump from Maven

* This field gets populated on newer versions of the aws-java-sdk-v2, fortunately

* Apply suggestions/code review from @reisingerf. Rollback aws-sdk version bump since it affects error messaging and "germane-ity" of this PR. Killing Triple/Tuple in next commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x Parity feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

2 participants