Fix clobbering of marshalled Accept header #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
approved these changes
Mar 28, 2019
| // format of the document returned by the service, such as GetExport | ||
| // https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-export-api.html. | ||
| // See the same fix in V1: | ||
| // https://github.com/aws/aws-sdk-java/blob/cd2275c07df8656033bfa9baa665354bfb17a6bf/aws-java-sdk-api-gateway/src/main/java/com/amazonaws/services/apigateway/internal/AcceptJsonRequestHandler.java#L29 |
There was a problem hiding this comment.
Another reason for this change is that customer can provide the header via overrideConfiguration and we should honor it :)
| @@ -0,0 +1,53 @@ | |||
| package software.amazon.awssdk.services.apigateway.internal; | |||
There was a problem hiding this comment.
Thanks for creating the test class! Missing copyright header.
dagnir
force-pushed
the
api-export-format
branch
from
4c7d697 to
9a06fcf
Compare
Codecov Report
@@ Coverage Diff @@
## master #1174 +/- ##
============================================
+ Coverage 58.97% 58.98% +0.01%
- Complexity 4592 4595 +3
============================================
Files 743 744 +1
Lines 23012 23020 +8
Branches 1720 1721 +1
============================================
+ Hits 13571 13579 +8
Misses 8754 8754
Partials 687 687
Continue to review full report at Codecov.
|
aws-sdk-java-automation
added a commit
that referenced
this pull request
Jan 29, 2021
…4d917114d Pull request: release <- staging/7a715510-b892-4064-bba4-2c84d917114d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Bug fix.
Testing
Unit tests to test interceptor and added integration test using
GetExport.Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense