Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RequestBody.fromRemainingByteBuffer() #1569

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Add RequestBody.fromRemainingByteBuffer() #1569

merged 1 commit into from
Jan 3, 2020

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Jan 2, 2020

Fixes #1534

Description

Motivation and Context

Testing

New unit tests.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir changed the title Add RequestBody.fromRemainingBytes() Add RequestBody.romRemainingByteBuffer() Jan 2, 2020
@dagnir dagnir changed the title Add RequestBody.romRemainingByteBuffer() Add RequestBody.fromRemainingByteBuffer() Jan 2, 2020
@dagnir dagnir merged commit aad53ed into aws:master Jan 3, 2020
@dagnir dagnir deleted the gh1534 branch January 3, 2020 17:50
aws-sdk-java-automation added a commit that referenced this pull request Jul 27, 2021
@aws-sdk-java-automation
Merge pull request #1569 from aws/staging/9fc19a84-036b-4a4a-9b53-f69…
2b447dc 
…a86ec7422

Pull request: release <- staging/9fc19a84-036b-4a4a-9b53-f69a86ec7422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmaizels bmaizels bmaizels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RequestBody.fromByteBuffer does not respect ByteBuffer's position
2 participants
@dagnir @bmaizels