Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE in RetryPolicy.hashCode() #2672

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Fix NPE in RetryPolicy.hashCode() #2672

merged 1 commit into from
Aug 23, 2021

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Aug 23, 2021

Motivation and Context

Description

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@@ -234,7 +234,7 @@ public int hashCode() {
result = 31 * result + Boolean.hashCode(additionalRetryConditionsAllowed);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary since it's a primitive boolean:

private final boolean additionalRetryConditionsAllowed;

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@dagnir dagnir merged commit be56f14 into aws:master Aug 23, 2021
@dagnir dagnir deleted the fix-hashcode branch August 23, 2021 21:40
aws-sdk-java-automation added a commit that referenced this pull request Aug 25, 2023
…f4c541390

Pull request: release <- staging/529ff03d-ca4e-4690-88b3-e38f4c541390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants