Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies to support future migration to Java 9. #271

Merged
merged 1 commit into from
Nov 6, 2017

Conversation

millems
Copy link
Contributor

@millems millems commented Nov 2, 2017

  1. Migrated from FindBugs to SpotBugs
  2. Upgraded any dependencies that no longer worked on Java 9
  3. Added explicit dependency on javax annotations for @generated annotation access.
  4. Fixed a warning from SpotBugs that was not caught by FindBugs.

@millems millems force-pushed the millem/java-9 branch 2 times, most recently from d8c466a to 6eecb79 Compare November 2, 2017 22:13
.travis.yml Outdated
@@ -1,6 +1,6 @@
language: java
jdk:
- oraclejdk8
- oraclejdk9
sudo: true
dist: precise
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we also need to update to Trusty to get 9

@spfink
Copy link
Contributor

spfink commented Nov 2, 2017

What kind of testing have you done to verify this will work for all consumers?

@millems
Copy link
Contributor Author

millems commented Nov 2, 2017

Talked about it, and it might be good to wait a while before upgrading to Java 9. I'd guess most testers are still on Java 8. Upgrading later on when more people have had a chance to upgrade is probably the better idea.

I'm going to tweak this PR to include everything BUT actually performing the java 9 upgrade. That'll make it a 1-character change to upgrade when we are ready.

1. Migrated from FindBugs to SpotBugs
2. Upgraded any dependencies that no longer worked on Java 9
3. Added explicit dependency on javax annotations for @generated annotation access.
4. Fixed a warning from SpotBugs that was not caught by FindBugs.
@millems millems changed the title Upgrade to Java 9. Upgrade dependencies to support future migration to Java 9. Nov 2, 2017
@brharrington
Copy link
Contributor

Talked about it, and it might be good to wait a while before upgrading to Java 9.

Does this mean that the 2.x SDK will require jdk9 or higher at runtime? Since jdk9 is not considered a long term stable release, it seems like it would be good if it could run on jdk8 until at least 18.9 is out.

As a side note, given you are still supporting jdk8 for now, why not configure a travis matrix build that verifies changes on both jdk8 and jdk9? We have been doing that and it has helped prevent a few regressions from coming in and breaking support for running on jdk9.

@millems millems merged commit 2dcf158 into master Nov 6, 2017
@millems millems deleted the millem/java-9 branch November 6, 2017 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants