Implementing Consumer<Builder> client operations #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spfink
approved these changes
Nov 11, 2017
kiiadi
force-pushed
the
kiiadi/consumer-builders-on-models
branch
from
0725586 to
f7f0a91
Compare
kiiadi
force-pushed
the
kiiadi/consumer-builders-on-client
branch
2 times, most recently
from
fa48607 to
2bfbec6
Compare
zoewangg
reviewed
Nov 13, 2017
| .collect(Collectors.toList())); | ||
| return methods; | ||
| .collect(toList())); | ||
| return methods.stream().sorted(Comparator.comparing(m -> m.name)).collect(toList()); |
There was a problem hiding this comment.
Question: I saw some places we are doing static imports and some are not. Do we want to make it more consistent?
zoewangg
reviewed
Nov 13, 2017
| // TODO This is inconsistent with how async client reuses method signature | ||
| static MethodSpec.Builder operationMethodSignature(IntermediateModel model, OperationModel opModel) { | ||
| private static MethodSpec.Builder operationBaseSignature(IntermediateModel model, | ||
| OperationModel opModel, |
There was a problem hiding this comment.
Alignment of parameters is off here
Quote from the comment Sam left on my PR. 😂
zoewangg
reviewed
Nov 13, 2017
| @@ -37,7 +37,7 @@ | |||
| */ | |||
| FILE, | |||
|
|
|||
| /** | |||
| CONSUMER_BUILDER, /** | |||
kiiadi
force-pushed
the
kiiadi/consumer-builders-on-client
branch
from
2bfbec6 to
baec9e3
Compare
kiiadi
force-pushed
the
kiiadi/consumer-builders-on-models
branch
from
73351c3 to
710b3af
Compare
kiiadi
force-pushed
the
kiiadi/consumer-builders-on-client
branch
from
baec9e3 to
a67663e
Compare
kiiadi
changed the base branch from
kiiadi/consumer-builders-on-models
to
master
kiiadi
force-pushed
the
kiiadi/consumer-builders-on-client
branch
from
a619d08 to
769658f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #278