Use java.util.Objects to implement equals, hashCode #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This creates a bit more garbage because it needs to load things into an array. I'm guessing we're balancing against jar size? How much does this help that? |
|
This uses |
|
Cool, I missed that! |
millems
reviewed
Nov 17, 2017
| } | ||
| if (!Objects.equals(booleanMember(), other.booleanMember()) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Any chance we could just do return Object.equals() && Object.equals() & ...?
|
Updated |
millems
reviewed
Nov 18, 2017
| memberModels.stream() | ||
| .skip(1) | ||
| .forEach(m -> adder.accept("&&", m)); | ||
| memberEqualsStmt.add(";"); |
There was a problem hiding this comment.
Does the PoetCollectors.toDelimitedCodeBlock make this a bit easier to implement?
There was a problem hiding this comment.
Nice! Didn't know that was there. Done
millems
approved these changes
Nov 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
java.util.Objectsto implementsequals()andhashCode().Motivation and Context
Should cut down on generated file size.
Testing
Updated reference tests.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense