Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding helper for profile credential provider that allows passing profile name #347

Merged
merged 1 commit into from
Dec 12, 2017

Conversation

kiiadi
Copy link
Contributor

@kiiadi kiiadi commented Dec 12, 2017

Description

Rather than having to call ProfileCredentialsProvider.builder.profileName("blah").build() one can now call : ProfileCredentialsProvider.create("blah")

Motivation and Context

Seemed like a common enough use-case to warrant a helper method.

Testing

Added new unit test

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG

License

  • I confirm that this pull request can be released under the Apache 2 license

Copy link
Contributor

@spfink spfink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: after you fix your test

…file name to create.

Seemed like a common enough use-case to warrant a helper method.
@kiiadi kiiadi force-pushed the kiiadi/profile-credential-provider-simple-method branch from 618eefe to 872f86f Compare December 12, 2017 18:23
@millems
Copy link
Contributor

millems commented Dec 12, 2017

This won't work after #296. I'd recommend against merging so that customers don't rely on it.

@kiiadi
Copy link
Contributor Author

kiiadi commented Dec 12, 2017

@millems as discussed offline - this should still work after #296 are you OK for me to merge?

@millems
Copy link
Contributor

millems commented Dec 12, 2017

Sure!

@kiiadi kiiadi merged commit a5ca461 into master Dec 12, 2017
@kiiadi kiiadi deleted the kiiadi/profile-credential-provider-simple-method branch December 13, 2017 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants