Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spotbugs bugs #543

Merged
merged 1 commit into from
Jun 13, 2018
Merged

Fix spotbugs bugs #543

merged 1 commit into from
Jun 13, 2018

Conversation

zoewangg
Copy link
Contributor

  • Enabled findbugs <failOnError>true</failOnError> and fixed reported bugs
  • Clean up code a bit

@zoewangg zoewangg requested a review from varunnvs92 June 12, 2018 17:29
<Or>
<Class name="software.amazon.awssdk.core.client.BaseAsyncClientHandler$InterceptorCallingHttpResponseHandler" />
<Class name="software.amazon.awssdk.core.client.BaseAsyncClientHandler$UnmarshallingSdkHttpResponseHandler" />
<Class name="software.amazon.awssdk.core.internal.http.async.SyncResponseHandlerAdapter" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure all the new values are false positives?
For example, this code seems to be unsafe

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is false positive.

We are passing SdkHttpFullResponse to headersReceived method.

SdkHttpResponse sdkResponse = SdkHttpFullResponse.builder()
.headers(fromNettyHeaders(response.headers()))
.statusCode(response.status().code())
.statusText(response.status().reasonPhrase())
.build();
channelContext.channel().attr(KEEP_ALIVE).set(HttpUtil.isKeepAlive(response));
requestContext.handler().headersReceived(sdkResponse);

@zoewangg zoewangg force-pushed the zoewang-fixFindbugsViolations branch from 576d3fb to b37bf3e Compare June 13, 2018 17:01
@zoewangg zoewangg force-pushed the zoewang-fixFindbugsViolations branch from b37bf3e to f733782 Compare June 13, 2018 17:47
@zoewangg zoewangg merged commit 16dafbc into master Jun 13, 2018
@zoewangg zoewangg deleted the zoewang-fixFindbugsViolations branch June 13, 2018 18:08
aws-sdk-java-automation added a commit that referenced this pull request Jun 25, 2019
…b727c9d3

Pull request: release <- staging/66c3a79a-c1fa-4328-af74-9b46b727c9d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants