Fix bug in ChecksumCalculatingInputStream #942
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #941
Bug Description
When request has content stream, UrlConnectionHttpClient copies the content stream to the connection output stream using IoUtils.copy method. The copy methods writes to the outputStream until the endOfStream is reached ie., in.read method returns -1. As ChecksumCalculatingInputStream returns 0 for eos, the copy method goes into infinite loop.
Fix: Make read method return -1 when eos is reached.
Testing
Verified the tests in reported issue passed after the change.