chore: remove redundant return from xml serialize (#1182)

aws · May 14, 2020 · 117e9ca · 117e9ca
1 parent 5a92d6b
commit 117e9ca
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/...degen/src/main/java/software/amazon/smithy/aws/typescript/codegen/XmlShapeSerVisitor.java b/...degen/src/main/java/software/amazon/smithy/aws/typescript/codegen/XmlShapeSerVisitor.java
@@ -78,8 +78,7 @@ protected void serializeCollection(GenerationContext context, CollectionShape sh
                 writer.openBlock("return node.reduce((acc: __XmlNode, workingNode: any) => {", "}", () -> {
                     // Add @xmlNamespace value of the target member.
                     AwsProtocolUtils.writeXmlNamespace(context, memberShape, "workingNode");
-                    writer.write("acc.addChildNode(workingNode);");
-                    writer.write("return acc;");
+                    writer.write("return acc.addChildNode(workingNode);");
                 });
                 writer.write(", new __XmlNode($S));", locationName);
             } else {
@@ -134,8 +133,7 @@ protected void serializeMap(GenerationContext context, MapShape shape) {
                     writer.openBlock("node.reduce((acc: __XmlNode, workingNode: any) => {", "}", () -> {
                         // Add @xmlNamespace value of the value member.
                         AwsProtocolUtils.writeXmlNamespace(context, valueMember, "workingNode");
-                        writer.write("acc.addChildNode(workingNode);");
-                        writer.write("return acc;");
+                        writer.write("return acc.addChildNode(workingNode);");
                     });
                     writer.write(", new __XmlNode($S));", valueName);
                 });

diff --git a/protocol_tests/aws-restxml/protocols/Aws_restXml.ts b/protocol_tests/aws-restxml/protocols/Aws_restXml.ts
@@ -4440,8 +4440,7 @@ const serializeAws_restXmlNestedStringList = (
   return input.map(entry => {
     const node = serializeAws_restXmlStringList(entry, context);
     return node.reduce((acc: __XmlNode, workingNode: any) => {
-      acc.addChildNode(workingNode);
-      return acc;
+      return acc.addChildNode(workingNode);
     }, new __XmlNode("member"));
   });
 };