Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn test:all doesn't run tests written in karma #671

Closed
trivikr opened this issue Jan 7, 2020 · 4 comments
Closed

yarn test:all doesn't run tests written in karma #671

trivikr opened this issue Jan 7, 2020 · 4 comments
Labels
CI/CD This is related to CI/CD feature-request New feature or enhancement. May require GitHub community feedback.

Comments

@trivikr
Copy link
Member

trivikr commented Jan 7, 2020

Describe the bug

To Reproduce (observed behavior)

  • Run yarn test:all
  • Notice that tests are not run for packages which use karma (like hash-blob-browser)

Expected behavior
Tests are run for packages which use karma - recommendation is to move them to Jest instead

@trivikr
Copy link
Member Author

trivikr commented Feb 25, 2020

Documentation on using Jest with Puppeteer https://jestjs.io/docs/en/puppeteer

@trivikr
Copy link
Member Author

trivikr commented Feb 25, 2020

QAWolf for writing browser tests faster https://www.qawolf.com/

@AllanZhengYP AllanZhengYP added feature-request New feature or enhancement. May require GitHub community feedback. and removed bug This issue is a bug. labels Mar 6, 2020
@AllanZhengYP
Copy link
Contributor

Currently we test packages with karma test explicitly like:

"test:all": "jest --coverage --passWithNoTests && lerna run test --scope @aws-sdk/stream-collector-browser --scope @aws-sdk/hash-blob-browser",

We will investigate jest-puppeteer solution. Label this as a feature request.

@AllanZhengYP AllanZhengYP added the CI/CD This is related to CI/CD label Mar 6, 2020
@trivikr trivikr closed this as completed Sep 15, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI/CD This is related to CI/CD feature-request New feature or enhancement. May require GitHub community feedback.
Projects
None yet
Development

No branches or pull requests

2 participants