Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for browser streaming #721

Merged
merged 8 commits into from
Jan 20, 2020

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Jan 13, 2020

Reopen #581

Per #102 browser streaming as removed from preview because ReadableStream support in browsers was not ideal back then. Now since most of the browser vendors support ReadableStream, we can enable the feature.

Previously, the fetch-http-handler returns a promise of blob for body, even when we expect the body to be streaming sometimes(e.g. S3 GetObject). After these change, we can return a ReadableStream for streaming response in browser. This would avoid loading all the resposne body data in the brwoser memory.

reference:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation

This comment has been minimized.

@AllanZhengYP
Copy link
Contributor Author

AllanZhengYP commented Jan 14, 2020

This CI is failing because my update to streaming-collector-browser package requires karma test, running jest on it will fail with Response is not defined. Now we run run jest directly to the whole workspace. We need a path to run karma only for some sub-packages. One way to achieve it is to run lerna exec "yarn test" in CI so we can run test script to each package.

Update: This issue is mentioned in #671

@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@AllanZhengYP
Copy link
Contributor Author

After fixing the CodeBuild image, the CI finally succeeds. Now this is ready to be reviewed.

@trivikr trivikr merged commit 133430c into aws:smithy-codegen Jan 20, 2020
@lock
Copy link

lock bot commented Jan 28, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants