-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for browser streaming #721
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This CI is failing because my update to Update: This issue is mentioned in #671 |
a81e50a
to
021bf27
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
8e5a85d
to
b1cde9b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
b8e6da5
to
d529151
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
After fixing the CodeBuild image, the CI finally succeeds. Now this is ready to be reviewed. |
3d60c59
to
9e81bd4
Compare
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Reopen #581
Per #102 browser streaming as removed from preview because
ReadableStream
support in browsers was not ideal back then. Now since most of the browser vendors support ReadableStream, we can enable the feature.Previously, the
fetch-http-handler
returns a promise ofblob
for body, even when we expect the body to be streaming sometimes(e.g. S3 GetObject). After these change, we can return aReadableStream
for streaming response in browser. This would avoid loading all the resposne body data in the brwoser memory.reference:
ReadableStream
browser support: https://caniuse.com/#search=ReadableStreamReadableStream
update for browser support data: Update ReadableStream compatibility in Safari mdn/browser-compat-data#5424Response
constructor: https://fetch.spec.whatwg.org/#response-classResponse
constructor browser compatibility: https://caniuse.com/#feat=mdn-api_response_responseBody
(e.g.Body.arraybuffer()
) update for browser support data: add body api safari, safari mobile, chrome android support mdn/browser-compat-data#5490Body
andReadable
stream support data is not accurate. They are actually supported bycurrent mainstream browsers, desktop and mobile. See above 2 PRs for more information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.