Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(clients): mark apiVersion as @internal #2019

Merged
merged 3 commits into from
Feb 11, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 11, 2021

Issue

Fixes: #1869
Fixes: #1986

Description

marks apiVersion configuration as internal, and explicitly calls out that it is not to be used by customer code.

Testing

Tested by verifying that VSCode shows the message in Intellisense.

Screenshot

Screen Shot 2021-02-10 at 4 56 24 PM


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title chore(clients): mark apiVersion as internal docs(clients): mark apiVersion as internal Feb 11, 2021
@trivikr trivikr changed the title docs(clients): mark apiVersion as internal docs(clients): mark apiVersion as @internal Feb 11, 2021
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: d2d42d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexforsyth alexforsyth merged commit 1a327c1 into aws:master Feb 11, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2021
@trivikr trivikr deleted the mark-apiVersion-as-internal branch March 15, 2021 04:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apiVersion autocomplete info Remove apiVersion from configuration
3 participants