Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update base64 codegen #2786

Merged
merged 2 commits into from
Sep 14, 2021

Conversation

JordonPhillips
Copy link
Member

Issue

n/a

Description

Updates codegen resulting from: smithy-lang/smithy-typescript#419

Additionally, removes suppressions for remaining base64 malformed request tests, as after this they're all resolved.

Testing

Generators were run off of smithy main and protocol tests / malformed request tests all passed.

Additional context

n/a


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@JordonPhillips JordonPhillips changed the title Update base64 codegen chore: update base64 codegen Sep 14, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #2786 (5ab23f3) into main (2b336a3) will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2786   +/-   ##
=======================================
  Coverage   60.17%   60.17%           
=======================================
  Files         548      548           
  Lines       28592    28592           
  Branches     7000     7000           
=======================================
  Hits        17204    17204           
  Misses      11388    11388           
Impacted Files Coverage Δ
...ent-lex-runtime-service/protocols/Aws_restJson1.ts 11.34% <0.00%> (ø)
...ocol_tests/aws-restjson/protocols/Aws_restJson1.ts 60.99% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b336a3...5ab23f3. Read the comment docs.

@JordonPhillips JordonPhillips merged commit e171183 into aws:main Sep 14, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants