Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sort exports using eslint rule sort-export-all #2908

Merged
merged 6 commits into from
Oct 18, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 17, 2021

Issue

We use eslint-plugin-simple-import-sort for sorting imports, but exports were not sorted.

Description

Sorts exports using eslint rule sort-export-all

Testing

  • Visually verified that exports were sorted in all workspaces.
  • Verified that yarn generate-clients commands also sorts exports using esprint

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from AllanZhengYP October 17, 2021 17:08
@codecov-commenter
Copy link

Codecov Report

Merging #2908 (c9b8219) into main (5c86f5a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2908   +/-   ##
=======================================
  Coverage   58.57%   58.57%           
=======================================
  Files         558      558           
  Lines       30249    30249           
  Branches     7443     7443           
=======================================
  Hits        17719    17719           
  Misses      12530    12530           
Impacted Files Coverage Δ
lib/lib-storage/src/chunks/getChunkStream.ts 100.00% <ø> (ø)
lib/lib-storage/src/chunks/getDataReadable.ts 100.00% <ø> (ø)
lib/lib-storage/src/Upload.ts 85.57% <100.00%> (ø)
lib/lib-storage/src/chunker.ts 72.22% <100.00%> (ø)
lib/lib-storage/src/runtimeConfig.ts 100.00% <100.00%> (ø)
...ckages/middleware-apply-body-checksum/src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c86f5a...c9b8219. Read the comment docs.

@trivikr trivikr merged commit 0a75f12 into aws:main Oct 18, 2021
@trivikr trivikr deleted the eslint-plugin-sort-export branch October 18, 2021 16:42
@github-actions
Copy link

github-actions bot commented Nov 2, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants