Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] test: serialization of Rest-JSON API input and Content-Type #2913

Closed
wants to merge 2 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 18, 2021

Issue

Internal JS-2855

Description

Tests serialization of Rest-JSON API Input and Content-Type

Testing

Protocol tests from smithy-lang/smithy#924


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2021

Codecov Report

Merging #2913 (ddc76ff) into main (0a75f12) will decrease coverage by 0.00%.
The diff coverage is 58.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2913      +/-   ##
==========================================
- Coverage   58.57%   58.57%   -0.01%     
==========================================
  Files         558      562       +4     
  Lines       30249    30493     +244     
  Branches     7443     7497      +54     
==========================================
+ Hits        17719    17861     +142     
- Misses      12530    12632     +102     
Impacted Files Coverage Δ
...l_tests/aws-restjson/src/RestJsonProtocolClient.ts 92.00% <ø> (ø)
..._tests/aws-restjson/src/protocols/Aws_restJson1.ts 43.81% <36.48%> (-0.33%) ⬇️
...-restjson/src/commands/TestBodyStructureCommand.ts 90.47% <90.47%> (ø)
.../aws-restjson/src/commands/TestNoPayloadCommand.ts 90.47% <90.47%> (ø)
...ws-restjson/src/commands/TestPayloadBlobCommand.ts 90.47% <90.47%> (ø)
...stjson/src/commands/TestPayloadStructureCommand.ts 90.47% <90.47%> (ø)
protocol_tests/aws-restjson/src/models/models_0.ts 90.26% <100.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a75f12...ddc76ff. Read the comment docs.

@trivikr
Copy link
Member Author

trivikr commented Oct 24, 2021

Closing, as these protocol_tests were updated for testing rest-json.
They would be updated with smithy version update.

@trivikr trivikr closed this Oct 24, 2021
@trivikr trivikr deleted the rest-json-content-type branch October 24, 2021 15:55
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants