docs(abort-controller): add message about browsers #4591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
reviewed
Mar 29, 2023
trivikr
approved these changes
Mar 29, 2023
syall
approved these changes
Mar 29, 2023
…troller.ts Co-authored-by: Trivikram Kamat <[email protected]>
syall
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
Not a blocker, but is there a reason why this isn't in a jest test?
There was a problem hiding this comment.
it could be, but there is no runtime component in this package so I thought it's unnecessary
3 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#4582
Description
Add message to not use the SDK's AbortController in browsers. Make global AbortController compatible with our interface (type fix)
Testing
added unit test