Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add smoke test traits dep #5664

Merged
merged 1 commit into from
Jan 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: add smoke test traits dep
Adds a dependency on smithy-smoke-test-traits in the sdk code gen
package so aws service models that use the smokeTests trait won't
fail to build because of unknown traits. Generated a client with
a smoke test and confirmed there was no diff.

Adding the dependency in the code gen package since it's the models
that need the dependency, not the code generator. When smoke tests
are implemented in the generator, we can add the dep there.
milesziemer committed Jan 10, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 39f93ea3c3ca921bbb9930e250fa31bc4de0769a
2 changes: 2 additions & 0 deletions codegen/sdk-codegen/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -43,7 +43,9 @@ plugins {
}

dependencies {
val smithyVersion: String by project
implementation(project(":smithy-aws-typescript-codegen"))
implementation("software.amazon.smithy:smithy-smoke-test-traits:$smithyVersion")
}

// This project doesn't produce a JAR.