add more unit test; fix browser parser

aws · Feb 3, 2020 · ab093ce · ab093ce
1 parent 020ff0b
commit ab093ce
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 3 deletions.
diff --git a/lib/model/api.js b/lib/model/api.js
@@ -3,7 +3,7 @@ var Operation = require('./operation');
 var Shape = require('./shape');
 var Paginator = require('./paginator');
 var ResourceWaiter = require('./resource_waiter');
-var Metadata = require('../../apis/metadata.json');
+var metadata = require('../../apis/metadata.json');
 
 var util = require('../util');
 var property = util.property;
@@ -35,7 +35,7 @@ function Api(api, options) {
   property(this, 'fullName', api.metadata.serviceFullName);
   property(this, 'serviceId', api.metadata.serviceId);
   if (serviceIdentifier) {
-      property(this, 'xmlNoDefaultLists', Metadata[serviceIdentifier].xmlNoDefaultLists, false);
+      property(this, 'xmlNoDefaultLists', metadata[serviceIdentifier].xmlNoDefaultLists, false);
   }
 
   memoizedProperty(this, 'className', function() {

diff --git a/lib/xml/browser_parser.js b/lib/xml/browser_parser.js
@@ -108,7 +108,10 @@ function parseStructure(xml, shape) {
         getElementByTagName(xml, memberShape.name);
       if (xmlChild) {
         data[memberName] = parseXml(xmlChild, memberShape);
-      } else if (!memberShape.flattened && memberShape.type === 'list') {
+      } else if (
+        !memberShape.flattened &&
+        memberShape.type === 'list' &&
+        !shape.api.xmlNoDefaultLists) {
         data[memberName] = memberShape.defaultValue;
       }
     }

diff --git a/test/xml/parser.spec.js b/test/xml/parser.spec.js