Support services not specified in metadata.json #3097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit aws#3087 introduced passing a `serviceIdentifier` to the constructor which needs to be present in the `metadata.json`. For private models thats not the case and checking for `xmlNoDefaultLists` fails.
Codecov Report
@@ Coverage Diff @@
## master #3097 +/- ##
==========================================
+ Coverage 97.05% 97.06% +0.01%
==========================================
Files 330 330
Lines 9534 9534
Branches 1751 1751
==========================================
+ Hits 9253 9254 +1
+ Misses 281 280 -1
Continue to review full report at Codecov.
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit #3087 introduced
passing a
serviceIdentifierto the constructor which needs to bepresent in the
metadata.json. For private models thats not the caseand checking for
xmlNoDefaultListsfails.Checklist
npm run testpassesnpm run add-change