fix: update S3 status 200 error behavior #4654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
fix/s3-200-errors
branch
5 times, most recently
from
4bb52ba to
c0b3864
Compare
siddsriv
approved these changes
Jun 27, 2024
trivikr
approved these changes
Jun 27, 2024
isaiahshall
approved these changes
Jun 27, 2024
kuhe
force-pushed
the
fix/s3-200-errors
branch
2 times, most recently
from
23d4216 to
a5c5b09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates S3 status-200 error behavior.
current classification of status-200 error is based on a hard-coded allowlist
this PR preserves the allowlist, but also expands the detection of status-200 errors to generic criteria:
</Error>, i.e. the root XML element is "Error".npm run testpasseschangelog is added,
npm run add-changeran
npx cucumber-js -t @s3