Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presigned URLs can not have expires_in: option of more than a week. #983

Closed
m-krull opened this issue Nov 2, 2015 · 2 comments
Closed
Labels
guidance Question that needs advice or information.

Comments

@m-krull
Copy link

m-krull commented Nov 2, 2015

The limit is set in aws-sdk-core/s3/presigner.rb.

To me this limit seems somewhat random as it is also not explained in the documentation or comments. Is that a limit set by the Amazon API? If it is, why is it handled in the presigner explicitly instead of using the failed request? If it is not, why is it enforced in the presigner?

@trevorrowe
Copy link
Member

This is a limitation of sigv4 presigned URLs. It is handled in the presigned as the error messages received from the api can be hard to decipher and frequently are consumed by users that did not generate the url.

@awood45
Copy link
Member

awood45 commented Nov 9, 2015

The presigner enforces the limit because that sigv4 limitation would otherwise cause errors (you could see this if you tried to manually generate a presigned request with a different limit.

@awood45 awood45 closed this as completed Nov 9, 2015
awood45 added a commit that referenced this issue Mar 3, 2017
GitHub issues/PRs #927 #983 and #1442 refer to this limit, so adding an
explanatory note to the documentation.
awood45 added a commit that referenced this issue Jun 29, 2017
GitHub issues/PRs #927 #983 and #1442 refer to this limit, so adding an
explanatory note to the documentation.
@srchase srchase added the guidance Question that needs advice or information. label Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guidance Question that needs advice or information.
Projects
None yet
Development

No branches or pull requests

4 participants