Get Correct sigv4_region When No endpointPrefix #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aws::IoTDataPlane::Client intentionally does not define `endpointPrefix` in the configured API metadata as a mechanic to force the user to supply an `:endpoint` value on client construction. The previous attempted fix failed to note that, in absence of `endpontPrefix`, all endpoints will match with the first selector, hard-coded to "us-east-1". This change will check for this case, and use your client configured region when it occurs. * Resolves GitHub Issue #1070 * Related to GitHub Issue #1052 * Fixes Regression In GitHub Pull Request #1053
|
The change looks good, but I would be more inclined to see a functional test for a specific service to exercise this. Try adding a test to the IoT data plane client spec that does this. |
Adds a functional test for non-us-east-1 regions, regarding extraction of the SigV4 signing region.
awood45
added a commit
that referenced
this pull request
Jan 22, 2016
Get Correct sigv4_region When No endpointPrefix
awood45
added a commit
that referenced
this pull request
Jan 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aws::IoTDataPlane::Client intentionally does not define
endpointPrefixin the configured API metadata as a mechanic to force the user to supply
an
:endpointvalue on client construction.The previous attempted fix failed to note that, in absence of
endpontPrefix, all endpoints will match with the first selector,hard-coded to "us-east-1". This change will check for this case, and use
your client configured region when it occurs.