Add missing "path" for CloudFormation "Stacks" collection #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdub
force-pushed
the
extend-cloudformation-resources
branch
from
e95dac6 to
bbad4d9
Compare
|
I'm looking at this, and it seems to still make the extra calls when inspecting stack data. It doesn't look wrong, but does this address the linked issue for you? |
|
Okay, I take that back, it looks like when I pulled down this branch to test, it wasn't actually taking in the diff. |
|
In any case, that looks good then. I'll merge this now, and push it upstream. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The adds a "path" to for the "Stacks" resource collection, allowing data to be loaded into Stack objects by the "DescribeStacks" call.
Addresses #1265.
As far as I could see, "Stacks" is the only "hasMany" collection that is missing a "path".