Add support for s3 host id #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awood45
approved these changes
Jun 7, 2017
| def call(context) | ||
| response = @handler.call(context) | ||
| h = context.http_response.headers | ||
| context[:host_id] = h['x-amz-id-2'] |
There was a problem hiding this comment.
Given that this field is S3-specific (especially in case other such fields come up for other services in the future), perhaps a name like :s3_host_id would be appropriate.
|
Updated with |
awood45
pushed a commit
that referenced
this pull request
Jun 29, 2017
* Add support for :s3_host_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for all request ids for s3: http://docs.aws.amazon.com/AmazonS3/latest/dev/troubleshooting.html
@awood45