Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Version 2] Fix AWS_PROFILE order in default credential chain #1541

Merged
merged 3 commits into from
Jun 20, 2017
Merged

[Version 2] Fix AWS_PROFILE order in default credential chain #1541

merged 3 commits into from
Jun 20, 2017

Conversation

cjyclaire
Copy link
Contributor

Addressing issue #1540

@awood45

@cjyclaire cjyclaire mentioned this pull request Jun 20, 2017
Closed
awood45
awood45 suggested changes Jun 20, 2017
View reviewed changes
Copy link
Member

@awood45 awood45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make sure we're careful the unit tests cover the full issue this time. Let's also ensure this is covered in the CHANGELOG.

aws-sdk-core/spec/aws/credential_provider_chain_spec.rb Outdated

env['AWS_PROFILE'] = 'fooprofile'
creds = CredentialProviderChain.new.resolve
expect(creds.profile_name).to eq('fooprofile')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the actual credentials from the stubbed credential files here, otherwise LGTM

@cjyclaire
Copy link
Contributor Author

Will merge once tests finished : )

@cjyclaire cjyclaire merged commit 9efb813 into master Jun 20, 2017
@cjyclaire cjyclaire deleted the fix-AWS-PROFILE branch June 21, 2017 21:28
awood45 pushed a commit that referenced this pull request Jun 29, 2017
@cjyclaire
[Version 2] Fix AWS_PROFILE order in default credential chain (#1541)
c2939e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awood45 awood45 awood45 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjyclaire @awood45