Reduce string allocations in Seahorse::Util.underscore.
#1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profiling script
```
require 'aws-sdk'
require 'memory_profiler'
MemoryProfiler.report do
Aws::S3
end.pretty_print
```
Before:
```
Total allocated: 12037984 bytes (134157 objects)
Total retained: 1823217 bytes (19143 objects)
allocated memory by gem
-----------------------------------
5607016 aws-sdk-core-2.9.43
4182950 rubygems
1078153 2.4.1/lib
995943 aws-sdk-resources-2.9.43
172234 oj-3.1.4
1688 2.4.0
allocated memory by file
-----------------------------------
3895019 /home/tgxworld/.rbenv/versions/2.4.1/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb
1838731 /home/tgxworld/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/aws-sdk-core-2.9.43/lib/seahorse/util.rb
1321647 /home/tgxworld/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/aws-sdk-core-2.9.43/lib/aws-sdk-core/json.rb
1200598 /home/tgxworld/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/aws-sdk-core-2.9.43/lib/aws-sdk-core/api/shape_map.rb
842413 /home/tgxworld/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/aws-sdk-core-2.9.43/lib/seahorse/model/shapes.rb
```
After:
```
Total allocated: 11751031 bytes (127005 objects)
Total retained: 1823217 bytes (19143 objects)
allocated memory by gem
-----------------------------------
5320063 aws-sdk-core-2.9.43
4182950 rubygems
1078153 2.4.1/lib
995943 aws-sdk-resources-2.9.43
172234 oj-3.1.4
1688 2.4.0
allocated memory by file
-----------------------------------
3895019 /home/tgxworld/.rbenv/versions/2.4.1/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb
1538292 /home/tgxworld/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/aws-sdk-core-2.9.43/lib/seahorse/util.rb
1321647 /home/tgxworld/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/aws-sdk-core-2.9.43/lib/aws-sdk-core/json.rb
1209779 /home/tgxworld/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/aws-sdk-core-2.9.43/lib/aws-sdk-core/api/shape_map.rb
842413 /home/tgxworld/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/aws-sdk-core-2.9.43/lib/seahorse/model/shapes.rb
```
tgxworld
force-pushed
the
reduce_allocations
branch
from
684a82c to
028d376
Compare
|
@tgxworld Thanks for the contribution and benchmarking details! looks good to me, I'll merge this. |
awood45
pushed a commit
that referenced
this pull request
Jun 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling script
Before:
After: