Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support S3 IAD Regional option #2194

Merged
merged 3 commits into from
Dec 18, 2019
Merged

Support S3 IAD Regional option #2194

merged 3 commits into from
Dec 18, 2019

Conversation

mullermp
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mullermp mullermp requested a review from awood45 December 18, 2019 22:26
@mullermp
Copy link
Contributor Author

backport of https://github.com/aws/aws-sdk-ruby/pull/2158/files

@mullermp
Copy link
Contributor Author 

AWS_REGION='us-east-1' cucumber -t @buckets
9 scenarios (9 passed)
39 steps (39 passed)

mullermp
mullermp commented Dec 18, 2019
View reviewed changes
AllanZhengYP
AllanZhengYP approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit test looks good.

trevorrowe
trevorrowe approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@trevorrowe trevorrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only had one minor question about dealing with mixed case strings, but that isn't an issue since we raise a helpful error.

@mullermp mullermp merged commit da61517 into version-2 Dec 18, 2019
@mullermp mullermp deleted the iad-regional-v2 branch December 18, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevorrowe trevorrowe trevorrowe approved these changes

@AllanZhengYP AllanZhengYP AllanZhengYP approved these changes

@awood45 awood45 Awaiting requested review from awood45

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mullermp @trevorrowe @AllanZhengYP