support/document usage with aws-go-sdk-v2

[kapilt]

Its not really apparent how to use go xray support with v2 Clients.

[luluzhao]

Hello @kapilt , thank you for your feedback. We will add this request into our backlog and make sure X-Ray Go SDK is compatible with AWS Go SDK version 2. In the meantime, feel free to send any PRs on this issue and we are happy to accept them. Please stay tuned.

[jason-riddle]

Any updates on this?

[luluzhao]

Hello @jason-riddle

Sorry for the late reply. aws-sdk-go is still under development and we will definitely start testing when v2 version is stable and ready for release. Please stay tuned.

[alikor]

If i would work on this feature would we need to be able to support v1 and v2 of the SDK? or like what has been done would with other v2 packages would you create a github.com/aws/aws-xray-sdk-go-v2?

[luluzhao]

Hello @alikor , sorry for the late response. Unfortunately, we're not going to support a preview version of xray sdk v2 like aws sdk did. Since aws go sdk v2 is still under developing, we cannot provide a specific version of xray sdk that based on a not finalized version of aws sdk. However, we will definitely work with aws sdk team to make sure xray sdk is up to date ASAP when aws sdk v2 is released.

[breml]

@luluzhao Thanks for your reply. My understanding is, that sdk v2 is pretty close to the final release for the following reasons:

1. the latest release is tagged with "preview.5" which sounds to me like "release candidate 5"
2. there have been only few changes in the last few months and from what I can tell, those have been mainly bug fixes. We are using v2 since more than 6 months now and we faced no problem with breaking changes so far.

Do you have some information about a possible release date of v2 of the sdk?

[danielpsf]

I'm looking forward to having support for V2, which will enhance my Serverless apps a lot!

[laverboy]

Is there anything that we can do to enable xray tracing of client calls using sdk-v2?

[cloudlena]

There is a pretty up to date fork you can use in the meantime: https://github.com/medisante/aws-xray-sdk-go

The fork shows how easy it is to enable v2 in X-Ray without changing any existing code. Would it be an option to create a PR from that fork @luluzhao? After all, the v2 SDK has been out for quite a while now and can hardly still be considered a developer preview (it has seen multiple releases without preview in the version number).

[laverboy]

I seem unable to use that fork. It looks like the master version with the v2 code in it hasn't been tagged so go only gets the version before the v2 code was added.

So adding the v2 file to the original code base would be great.

[laverboy]

Ok so for others who want to use the fork, I was being a bit dim earlier. You can just use

go get github.com/medisante/aws-xray-sdk-go/xray@awsv2

as a replacement. Until they add the code into the official branch.

[cloudlena]

@laverboy, you can also just add the following line to the bottom of your go.mod file:

replace github.com/aws/aws-xray-sdk-go => github.com/medisante/aws-xray-sdk-go v0.0.0-20190718070426-8b9ae96b5ac3

From then on you can use it as github.com/aws/aws-xray-sdk-go in your code.

[Cyberax]

If you're interested, I've ported the whole XRay SDK to v2 version of the Go SDK, with normal Go modules. No more V1 dependencies!

Link: https://github.com/Cyberax/aws-xray-sdk-go

[laverboy]

Any more on supporting v2, doesn't look like it is going away any time soon?

[bhautikpip]

Hi,

aws-sdk-v2 is still in Developer preview (beta) version. I believe we would still want to wait for aws-sdk-v2 to go GA (generally available) before we merge any code to our official branch. Meanwhile, community can utilize posted recommendations in this thread. Those recommendations looks neat to me.

[corymhall]

@bhautikpip any timeline on this now that the aws-sdk-go-v2 is GA?

https://aws.amazon.com/about-aws/whats-new/2021/01/aws-sdk-for-go-version-2-now-generally-available/

[bhautikpip]

X-Ray Go SDK v1.6.0 is now released and includes aws sdk v2 support so resolving this issue.