Fixed one source of memory leak #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he Done channel is nil
JakeKalstad
approved these changes
Dec 5, 2019
willarmiros
approved these changes
Dec 11, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Background context, the Done channel is nil
Issue #, if available:
#51
Description of changes:
Don't bother selecting a nil channel because it waits forever and leaks memory.
Issue 51 has a more comprehensive fix suggested by Cyberax, but if not going to integrate that fix or there some hold-up, at least make this trivial fix in the mean time.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.