Fix golint warnings #170
Fix golint warnings #170
Conversation
|
Hi @shogo82148, Thanks for opening this PR. Really appreciate your efforts! test cases are failing in lambda_go.test. Looks like could because of new context key introduced ? |
|
I think it is another problem, because the recent commit 62e6c36 didn't change I'm worrying that f6352d3 may not be acceptable. |
|
oh, the context key |
xray/lambda_test.go
Outdated
| @@ -8,6 +8,9 @@ import ( | |||
| ) | |||
|
|
|||
| func TestLambdaSegmentEmit(t *testing.T) { | |||
| // go-lint warns "should not use basic type string as key in context.WithValue", | |||
| // but it must be string type because the trace header comes from aws/aws-lambda-go. | |||
There was a problem hiding this comment.
might want to remove this comment.
|
Hi @shogo82148, test case is failing because of this line (segment.go - Line 98) (https://github.com/aws/aws-xray-sdk-go/pull/170/files#diff-4178d11b198e2b2e67f13586d5f83fc5R98). We might need to change this as URL and then we should be good to go with this changes. |
|
Hi @shogo82148, would you mind resolving the conflicts and add URL (segment.go - Line 98) instead of Url. This is PR is good to go other than that. |
Issue #, if available:
Description of changes:
There are some golangci-lint warnings.
https://travis-ci.org/aws/aws-xray-sdk-go/jobs/635402231
This pull request will fix them.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.