Integration test #270
Integration test #270
Conversation
…integrationTest
|
|
||
| steps: | ||
| - name: Checkout X-Ray Go SDK | ||
| uses: actions/checkout@v2 |
There was a problem hiding this comment.
Does this actually build the SDK source code? If not, where does this happen?
There was a problem hiding this comment.
This step is for checking out the code. It checks out the code from master branch and this step runs on Github's runner. (ubuntu-latest)
| @@ -0,0 +1,5 @@ | |||
| region = "us-west-2" | |||
|
|
|||
| bucket_key = "beanstalk/deploy.zip" | |||
There was a problem hiding this comment.
Where do we put the ZIP in this bucket?
There was a problem hiding this comment.
good question. It picks up the zip from ./terraform directory and I have mentioned that in source_path of the bucket.
| @@ -0,0 +1,140 @@ | |||
| name: Integration Testing | |||
| on: push | |||
There was a problem hiding this comment.
Do we want this running on PRs as well?
There was a problem hiding this comment.
I feel we can right now run on push only changes and then we can introduce on PRs as well. I think that is something we can wait on and collect some data points on what would be more useful. Ideally running on PR would be causing more stress on single aws account (in terms of ELB and other resources) because tests will run on every commit.
| run: rsync -r * sample-apps/http-server/aws-xray-sdk-go --exclude sample-apps/ | ||
|
|
||
| - name: Zip up the deployment package | ||
| run: zip -r deploy.zip . -x '*.git*' |
There was a problem hiding this comment.
No big deal, but for the future you can consider using git archive
There was a problem hiding this comment.
good call. Thanks!
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.