Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dbname issue #273

Merged
merged 6 commits into from
Jan 26, 2021
Merged

Dbname issue #273

merged 6 commits into from
Jan 26, 2021

Conversation

bhautikpip
Copy link
Contributor

Issue #, if available:

Description of changes:

Appended host to the subsegment name in order to give different identity of 2 database with same name.

  1. This case will only work for known DSL where host is parsable

So for know DSL subsegment will look like: dbname@host as per issue #231

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@willarmiros willarmiros requested a review from srprash January 12, 2021 00:47
srprash
srprash approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@srprash srprash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bhautikpip bhautikpip merged commit bd68eed into aws:master Jan 26, 2021
@bhautikpip bhautikpip mentioned this pull request Feb 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srprash srprash srprash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhautikpip @srprash