Support subscribing to SNS ARNs #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
requested review from
jamesls,
joguSD,
kyleknap and
stealthycoin
stealthycoin
approved these changes
Jan 14, 2019
Codecov Report
@@ Coverage Diff @@
## master #1048 +/- ##
==========================================
+ Coverage 95.47% 95.48% +<.01%
==========================================
Files 27 27
Lines 4488 4494 +6
Branches 563 565 +2
==========================================
+ Hits 4285 4291 +6
Misses 131 131
Partials 72 72
Continue to review full report at Codecov.
|
This updates `@app.on_sns_message` to accept either the topic name or the topic ARN rather than just the name. While accepting the name can be a simpler experience, it prevents users from subscribing to topics that are in other regions or other accounts.
JordonPhillips
force-pushed
the
sns-arns
branch
from
d821314 to
03b6d58
Compare
stealthycoin
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
@app.on_sns_messageto accept either the topic name orthe topic ARN rather than just the name. While accepting the name can
be a simpler experience, it prevents users from subscribing to topics
that are in other regions or other accounts.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.