Validate you don't have OPTIONS when cors=True #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You'll get an error message from API gateway about a conflict exception which isn't that helpful. By adding it to the validation step here, we get a much clearer error message: ``` ValueError: Route entry cannot have both cors=True and methods=['OPTIONS', ...] configured. When CORS is enabled, an OPTIONS method is automatically added for you. Please remove 'OPTIONS' from the list of configured HTTP methods for: /badview ``` Closes aws#142.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You'll get an error message from API gateway about a conflict
exception which isn't that helpful. By adding it to the
validation step here, we get a much clearer error message:
Closes #142.