Pass user provided api gateway stage to config #325
Merged
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't passing this value to the factory obj when creating the config so --api-gateway-stage was being ignored.
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
=======================================
Coverage 89.13% 89.13%
=======================================
Files 18 18
Lines 1905 1905
Branches 231 231
=======================================
Hits 1698 1698
Misses 152 152
Partials 55 55
Continue to review full report at Codecov.
|
stealthycoin
approved these changes
May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't passing this value to the factory obj
when creating the config so --api-gateway-stage
was being ignored.
cc @stealthycoin