Fix API Gateway stage not being set correctly #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stealthycoin
force-pushed
the
fix-stages
branch
from
27a2a11 to
38d435c
Compare
Codecov Report
@@ Coverage Diff @@
## master #475 +/- ##
==========================================
- Coverage 94.01% 93.98% -0.04%
==========================================
Files 18 18
Lines 2940 2941 +1
Branches 380 380
==========================================
Hits 2764 2764
Misses 129 129
- Partials 47 48 +1
Continue to review full report at Codecov.
|
jamesls
approved these changes
Aug 14, 2017
The API Gateway stage is not set correctly since it was renamed from dev to api. This change enforces the 'api' default all the way through the config layer and CLI layer rather than making the end code that consumes the configuration manually enforce a default everywhere the api gateway stage name is used. fixes aws#470
stealthycoin
force-pushed
the
fix-stages
branch
from
38d435c to
ccce980
Compare
stealthycoin
added a commit
that referenced
this pull request
Aug 14, 2017
Fix API Gateway stage not being set correctly
|
Just ran into this problem. Any idea when the fix will get pushed to a new PyPi release? |
|
Version 1.0.1, which includes this fix, was just released on pypi. |
|
I'm using 1.0.1 and within config.json, |
|
@johntmyers Thanks for reporting, I've created an issue to track this here: #495 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API Gateway stage is not set correctly since it was renamed from dev
to api. This change enforces the 'api' default all the way through the
config layer and CLI layer rather than making the end code that consumes
the configuration manually enforce a default everywhere the api gateway
stage name is used.
fixes #470
@achautha Thanks for the contribution. I added a few more tests and more strict defaults in the Config object itself.
closes #474