Fix abi3 packaging #785
Merged
Fix abi3 packaging #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3 has an ABI called abi3 which is the CPython 3 Stable ABI which is compatible with any version of Python 3 after 3.2. The packager previously did not recognize these as being compatible with the Lambda abi of cp36m and would not use them. This fix adds abi3 as a valid abi for python 3. This fixes automatic packaging of cryptography 2.2.x since it removed its specific python 3 wheel files in favor of a single cp34 abi3 wheel.
Codecov Report
@@ Coverage Diff @@
## master #785 +/- ##
=======================================
Coverage 94.91% 94.91%
=======================================
Files 21 21
Lines 3661 3661
Branches 470 470
=======================================
Hits 3475 3475
Misses 124 124
Partials 62 62
Continue to review full report at Codecov.
|
jamesls
approved these changes
Apr 4, 2018
dstufft
approved these changes
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3 has an ABI called abi3 which is the CPython 3 Stable ABI which
is compatible with any version of Python 3 after 3.2. The packager
previously did not recognize these as being compatible with the Lambda
abi of cp36m and would not use them. This fix adds abi3 as a valid abi
for python 3.
This fixes automatic packaging of cryptography 2.2.x since it removed
its specific python 3 wheel files in favor of a single cp34 abi3 wheel.
fixes #764