Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change EnvironmentVariables to Environment #797

Conversation

stealthycoin
Copy link
Contributor

@stealthycoin stealthycoin commented Apr 12, 2018

To set an environment variable for a Lambda funciton through
CloudFormation the Environment key is needed rather than
EnvironmentVariables.

fixes #795

Copy link
Contributor

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@codecov-io
Copy link

codecov-io commented Apr 12, 2018

Codecov Report

Merging #797 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #797   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files          21       21           
  Lines        3669     3669           
  Branches      471      471           
=======================================
  Hits         3483     3483           
  Misses        124      124           
  Partials       62       62
Impacted Files Coverage Δ
chalice/package.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0335862...1d27cb4. Read the comment docs.

To set an environment variable for a Lambda funciton through
CloudFormation the Environment key is needed rather than
EnvironmentVariables.
@stealthycoin stealthycoin force-pushed the fix-environment-variables-in-cloudformation branch from bb9543d to 1d27cb4 Compare April 13, 2018 00:04
@stealthycoin stealthycoin merged commit 22a1d91 into aws:master Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package.py creates AWS::Serverless::Function Environment Variables property incorrectly
4 participants